Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Report analytics before running command. #8

Merged
merged 4 commits into from
Nov 18, 2024
Merged

fix: Report analytics before running command. #8

merged 4 commits into from
Nov 18, 2024

Conversation

hampuslavin
Copy link
Contributor

@hampuslavin hampuslavin commented Nov 18, 2024 •
edited
Loading

Description

@hampuslavin hampuslavin requested a review from SandPod November 18, 2024 09:00
@hampuslavin hampuslavin force-pushed the hl_2853_fix_analytics branch from a955ae5 to b0825f2 Compare November 18, 2024 09:01
SandPod
SandPod reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing tests that validate the trigger is called even if the command exists.
Is that possible to add?

Two questions.

This is the original implementation of the trigger that did it before the command ran, maybe some inspiration could be taken from there:

https://github.com/serverpod/serverpod/blob/4aa3a1eff01f613f4a88dcbcffcc952dc340e1fe/tools/serverpod_cli/bin/serverpod_cli.dart#L166-L184

lib/src/better_command_runner/better_command_runner.dart Show resolved Hide resolved
lib/src/better_command_runner/better_command_runner.dart Show resolved Hide resolved
SandPod
SandPod approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Had a suggestion to make the comment even more clear.

lib/src/better_command_runner/better_command_runner.dart Show resolved Hide resolved
@hampuslavin hampuslavin merged commit b85e816 into main Nov 18, 2024
3 checks passed
@hampuslavin hampuslavin deleted the hl_2853_fix_analytics branch November 18, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandPod SandPod SandPod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI analytics events are not reported if process is killed.
2 participants
@hampuslavin @SandPod